From a9a3af5e99abea9e17d6aa578b50fef3807c7169dc38b50dda4d9ec3fd6e99ec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E6=96=9F=E9=85=8C=20=E9=B5=AC=E5=85=84?= <tgckpg@gmail.com>
Date: Sun, 22 Mar 2026 18:07:35 +0800
Subject: [PATCH] Removed download-packages as makefile already has dependency
 support

---
 makefile | 37 ++++++++++++++++++++-----------------
 1 file changed, 20 insertions(+), 17 deletions(-)

diff --git a/makefile b/makefile
index 4cd30b1..a482495 100644
--- a/makefile
+++ b/makefile
@@ -3,25 +3,28 @@ export
 
 TAG ?= dev
 
-define fetch_if_missing
-	@if [ ! -f "$1" ]; then \
-		echo "Downloading $1"; \
-		curl -L -o "$1" "$2"; \
-	fi
-endef
+PACKAGES_DIR := packages
 
-ALPINE_SERIES := $(word 1,$(subst ., ,${ALPINE_VER})).$(word 2,$(subst ., ,${ALPINE_VER}))
+BUSYBOX_TAR := $(PACKAGES_DIR)/busybox-$(BUSYBOX_VERSION).tar.gz
+ALPINE_TAR  := $(PACKAGES_DIR)/alpine-minirootfs-$(ALPINE_VER)-$(ALPINE_ARCH).tar.gz
+NXP_TAR     := $(PACKAGES_DIR)/$(NXP_VERSION).tar.gz
+CRIO_TAR    := $(PACKAGES_DIR)/$(CRIO_VERSION).tar.gz
 
-download-packages:
-	@mkdir -p packages
+$(BUSYBOX_TAR):
+	@mkdir -p $(PACKAGES_DIR)
+	curl -L -o $@ "https://github.com/mirror/busybox/archive/refs/tags/$(BUSYBOX_VERSION).tar.gz"
 
-	$(call fetch_if_missing,packages/busybox-${BUSYBOX_VERSION}.tar.gz,https://github.com/mirror/busybox/archive/refs/tags/${BUSYBOX_VERSION}.tar.gz)
+$(ALPINE_TAR):
+	@mkdir -p $(PACKAGES_DIR)
+	curl -L -o $@ "https://dl-cdn.alpinelinux.org/alpine/v$(ALPINE_SERIES)/releases/$(ALPINE_ARCH)/alpine-minirootfs-$(ALPINE_VER)-$(ALPINE_ARCH).tar.gz"
 
-	$(call fetch_if_missing,packages/alpine-minirootfs-${ALPINE_VER}-${ALPINE_ARCH}.tar.gz,https://dl-cdn.alpinelinux.org/alpine/v$(ALPINE_SERIES)/releases/${ALPINE_ARCH}/alpine-minirootfs-${ALPINE_VER}-${ALPINE_ARCH}.tar.gz)
+$(NXP_TAR):
+	@mkdir -p $(PACKAGES_DIR)
+	curl -L -o $@ "https://github.com/nxp-qoriq/linux/archive/refs/tags/$(NXP_VERSION).tar.gz"
 
-	$(call fetch_if_missing,packages/${NXP_VERSION}.tar.gz,https://github.com/nxp-qoriq/linux/archive/refs/tags/${NXP_VERSION}.tar.gz)
-
-	$(call fetch_if_missing,packages/${CRIO_VERSION}.tar.gz,https://storage.googleapis.com/cri-o/artifacts/${CRIO_VERSION}.tar.gz)
+$(CRIO_TAR):
+	@mkdir -p $(PACKAGES_DIR)
+	curl -L -o $@ "https://storage.googleapis.com/cri-o/artifacts/$(CRIO_VERSION).tar.gz"
 
 build-base:
 	docker build \
@@ -29,7 +32,7 @@ build-base:
 	--build-arg TAG=$(TAG) \
 	-t $(DOCKER_IMAGE_ROOT)/build-base:$(TAG) .
 
-kernel-build: build-base
+kernel-build: build-base $(NXP_TAR)
 	docker build \
 	-f docker/kernel-build.Dockerfile \
 		--build-arg DOCKER_IMAGE_ROOT=$(DOCKER_IMAGE_ROOT) \
@@ -40,7 +43,7 @@ kernel-build: build-base
 		--build-arg DEVICE_TREE_TARGET=$(DEVICE_TREE_TARGET) \
 	-t $(DOCKER_IMAGE_ROOT)/kernel-build:$(TAG) .
 
-fit-build: kernel-build
+fit-build: kernel-build $(BUSYBOX_TAR)
 	docker build \
 	-f docker/fit-build.Dockerfile \
 		--build-arg DOCKER_IMAGE_ROOT=$(DOCKER_IMAGE_ROOT) \
@@ -60,7 +63,7 @@ itb: fit-build
 		--output type=local,dest=./out \
 	-t $(DOCKER_IMAGE_ROOT)/itb:$(TAG) .
 
-buildenv-alpine: build-base
+buildenv-alpine: build-base $(ALPINE_TAR) $(CRIO_TAR)
 	docker build \
 	-f docker/alpine.Dockerfile \
 		--build-arg DOCKER_IMAGE_ROOT=$(DOCKER_IMAGE_ROOT) \